Php photo gallery TWG | JFUploader | TWG Flash upload | WFU | Forum

Get help for TinyWebGallery, the best image gallery. The forum is also home for the Joomla JFUploader, TWG Flash Uploader and the Wordpress flash uploader.
It is currently 19. Sep 2018, 19:34

All times are UTC + 1 hour [ DST ]




Post new topic Reply to topic  [ 4 posts ] 
Author Message
PostPosted: 8. Dec 2009, 18:05 
Offline

Joined: 6. Dec 2009, 09:55
Posts: 9
Location: Lithuania, Kaunas
Hello. I'm new and happy user of TWG v1.7.8.1
Great gallery!

I've noticed, that wrong email addresses are accepted while user tries to subscribe for gallery updates. The problem seems to be in checkmail() function in i_email_user.php (line 146):

function checkmail($string)
{
$test1 = preg_match("blah-blah-blah", $string);
if ($test1) {
return testEmailDomain($string);
} else {
return false; //should be true
}
}


Top
 Profile  
 
 Post subject:
PostPosted: 8. Dec 2009, 18:51 
Offline
Site Admin
User avatar

Joined: 1. Aug 2005, 12:53
Posts: 10892
?

in my code it looks like:

else {
return true;
}

So you think it should return false?


Top
 Profile  
 
 Post subject:
PostPosted: 8. Dec 2009, 18:58 
Offline

Joined: 6. Dec 2009, 09:55
Posts: 9
Location: Lithuania, Kaunas
Sorry - messed up my example. :oops:
Current code is as you mentioned - if provided address matches email pattern - script goes for further (url) verification.
else (address doesn't match email pattern - e.g. simple 'aaaaa') - script returns TRUE.
Should return FALSE.


Top
 Profile  
 
 Post subject:
PostPosted: 8. Dec 2009, 19:03 
Offline
Site Admin
User avatar

Joined: 1. Aug 2005, 12:53
Posts: 10892
you are right - I changed it in the code.

It will be available in 1.8.

- Michael


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 4 posts ] 

All times are UTC + 1 hour [ DST ]


Who is online

Users browsing this forum: No registered users and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
powered by phpbb | Datenschutz/ Privacy policy