Php photo gallery TWG | JFUploader | TWG Flash upload | WFU | Forum

Get help for TinyWebGallery, the best image gallery. The forum is also home for the Joomla JFUploader, TWG Flash Uploader and the Wordpress flash uploader.
It is currently 19. Jun 2018, 07:09

All times are UTC + 1 hour [ DST ]




Post new topic Reply to topic  [ 7 posts ] 
Author Message
PostPosted: 30. Mar 2010, 14:34 
Offline

Joined: 30. Mar 2010, 14:05
Posts: 6
If you set $show_subdirs_first = true and $subfolders_only_once = true all is fine. Setting $show_subdirs_first = false and $subfolders_only_once = true the latter is ignored.

inc/index.inc.php 319-328:
Code:
  if ($show_subdirs_first) {
      if ($subfolders_only_once && $twg_offset == 0 ) {
      ceil(show_folders($path, $twg_foffset, $twg_offset, $twg_album) * 1.4);
    } else if (!$subfolders_only_once)  {
      $minus_rows = ceil(show_folders($path, $twg_foffset, $twg_offset, $twg_album) * 1.4);
    }
    if ($minus_rows >= $thumbnails_y) {
         $minus_rows = $thumbnails_y -1;
      }
   }


Request:
Allow $show_subdirs_first = false and $subfolders_only_once = true.

TWG Version 1.8


Top
 Profile  
 
 Post subject:
PostPosted: 30. Mar 2010, 20:18 
Offline
Site Admin
User avatar

Joined: 1. Aug 2005, 12:53
Posts: 10833
I have added this to my local build. I'm investigating a issue with ie and ssl and download. When this is solved I make a small update...

If you want to test please send me an e-mail...

- Michael.


Top
 Profile  
 
 Post subject:
PostPosted: 31. Mar 2010, 12:58 
Offline

Joined: 30. Mar 2010, 14:05
Posts: 6
I found another oddity in this context.

Settings are
$show_subdirs_first = true
$subfolders_only_once = true
$autodetect_maximum_thumbnails = true
Using a gallery with lets say p.e. 100 pics and one subfolder.

$autodetect_maximum_thumbnails = true advertises to prevent scrollbars by reducing the amount of images on thumbnail pages, but this only works on the second page and beyond. One the first page (with the subfolder shown) the calculation fails.

Quote:
If you want to test please send me an e-mail.
Ok, thanks for the offer!


Top
 Profile  
 
 Post subject:
PostPosted: 31. Mar 2010, 13:39 
Offline
Site Admin
User avatar

Joined: 1. Aug 2005, 12:53
Posts: 10833
Right.

I have written this in the documentation of $subfolders_only_once too.
This is done because otherwise offsets and paging have to be reimplemented only for this first page.

- Michael


Top
 Profile  
 
 Post subject:
PostPosted: 31. Mar 2010, 13:49 
Offline

Joined: 30. Mar 2010, 14:05
Posts: 6
From the config.php:
Quote:
but otherwise the whole secrion of the pager has to be completely rewritten and this will be done in 1.8 but not in 1.7 anymore.


Ok, so it's your intention to fix this in the 1.8 branch. :-)

Misunderstanding, my bad, sorry! I thought you implemented this fix already in the first release on the 1.8 branch.


Top
 Profile  
 
 Post subject:
PostPosted: 31. Mar 2010, 14:17 
Offline
Site Admin
User avatar

Joined: 1. Aug 2005, 12:53
Posts: 10833
No - it's still on the todo for 1.8.x (3 more releases are already full with new stuff).

- Michael


Top
 Profile  
 
 Post subject:
PostPosted: 31. Mar 2010, 14:22 
Offline

Joined: 30. Mar 2010, 14:05
Posts: 6
Quote:
3 more releases are already full with new stuff
Sounds good! Thanks for the great work! :-)


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 7 posts ] 

All times are UTC + 1 hour [ DST ]


Who is online

Users browsing this forum: No registered users and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
powered by phpbb | Datenschutz/ Privacy policy